Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editorial] Max points on a line #4572

Merged
merged 16 commits into from
Jul 4, 2024
Merged

[Editorial] Max points on a line #4572

merged 16 commits into from
Jul 4, 2024

Conversation

brebenelmihnea
Copy link
Contributor

@brebenelmihnea brebenelmihnea commented Jul 1, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@brebenelmihnea brebenelmihnea requested a review from dongliuu as a code owner July 1, 2024 11:38
SansPapyrus683
SansPapyrus683 requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might just be me, but your code does seem to be getting better

@brebenelmihnea
Copy link
Contributor Author

https://leetcode.com/problems/max-points-on-a-line/submissions/1305898431/
image

SansPapyrus683
SansPapyrus683 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro why'd you undo my code changes 💀

@ryanchou-dev ryanchou-dev enabled auto-merge July 1, 2024 22:53
@brebenelmihnea
Copy link
Contributor Author

bro why'd you undo my code changes 💀

🤦🏻 when i make changes i do them in my local editor to make sure the code still compiles; i didn't see you made changes; sorry

@SansPapyrus683
Copy link
Contributor

there's merge conflicts 💀

@brebenelmihnea
Copy link
Contributor Author

it was a conflict with my other PR 💀

@ryanchou-dev ryanchou-dev merged commit abed757 into cpinitiative:master Jul 4, 2024
3 checks passed
@brebenelmihnea brebenelmihnea deleted the max-points-on-a-line branch July 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@ryanchou-dev ryanchou-dev ryanchou-dev approved these changes

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brebenelmihnea @SansPapyrus683 @ryanchou-dev